Skip to content

feat(root): enhance rollback workflow to support multiple revisions and error handling #8500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

feat(root): enhance rollback workflow to support multiple revisions and error handling #8500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/rollback.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ run-name: >
github.event.inputs.rollback_ws == 'true' && 'ws, ' || ''
}}${{
github.event.inputs.rollback_webhook == 'true' && 'webhook ' || ''
}}on ${{ github.event.inputs.environment }}
}}on ${{ github.event.inputs.environment }} (${{
github.event.inputs.revisions_to_rollback
}} revisions)
description: Rollback deployment to the previous task definition for selected services in the specified environment.
concurrency:
group: "rollback-${{ github.event.inputs.environment }}"
Expand Down Expand Up @@ -51,6 +53,12 @@ on:
required: true
type: boolean
default: true

revisions_to_rollback:
description: 'Number of revisions to rollback (default: 1)'
required: true
type: number
default: 1

rollback_signoff:
description: "This will rollback the selected services to the previous task definition. This won't rollback any database migration or environment changes. Do you agree?"
Expand Down Expand Up @@ -212,8 +220,13 @@ jobs:
index=$(echo "$task_definition_list" | grep -n "$current_task_definition_arn" | cut -d ':' -f 1)
if [ -n "$index" ]; then
if [ "$index" -ge 1 ]; then # Greater than or equal to 1
previous_index=$((index + 1))
revisions_to_rollback=${{ github.event.inputs.revisions_to_rollback }}
previous_index=$((index + revisions_to_rollback))
previous_task_definition_arn=$(echo "$task_definition_list" | sed -n "${previous_index}p")
if [ -z "$previous_task_definition_arn" ]; then
echo "Error: Cannot rollback $revisions_to_rollback revisions. Not enough previous versions available."
exit 1
fi
echo "previous_task_definition_arn=$previous_task_definition_arn" >> $GITHUB_ENV
else
echo "Invalid index value: $index"
Expand Down
Loading