Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import lodash from 'lodash';
import { Injectable } from '@nestjs/common';
import { ControlValuesRepository, EnvironmentEntity, OrganizationEntity, UserEntity } from '@novu/dal';
import { ControlValuesLevelEnum, FeatureFlagsKeysEnum } from '@novu/shared';
import { FeatureFlagsService, Instrument, InstrumentUsecase } from '@novu/application-generic';

import { keysToObject } from '../../util/utils';
import { collectKeys, keysToObject } from '../../util/utils';
import { buildVariables } from '../../util/build-variables';
import { CreateVariablesObjectCommand } from './create-variables-object.command';
import { isStringifiedMailyJSONContent } from '../../../environments-v1/usecases/output-renderers/maily-to-liquid/wrap-maily-in-liquid.command';
Expand Down Expand Up @@ -65,20 +66,56 @@
);

const hasUsedEvents = !!(step.events && typeof step.events === 'string');
if (hasUsedEventCount || hasUsedEventsLength || hasUsedEvents) {
step.events = Array.isArray(step.events)
? step.events
const { events } = step;
/**
* Check if events is an object and has a payload property.
*/
const hasUsedEventsWithPayload = !!(
events &&
typeof events === 'object' &&
!Array.isArray(events) &&
'payload' in events
);
let variableNameAfterpayload = ['name'];

Check warning on line 79 in apps/api/src/app/workflows-v2/usecases/create-variables-object/create-variables-object.usecase.ts

View workflow job for this annotation

GitHub Actions / Spell check

Unknown word (Afterpayload)
if (hasUsedEventsWithPayload) {
/**
* If events is an object and has a payload property, collect keys from the payload.
* e.g. [payload.foo.bar]
*/
variableNameAfterpayload = collectKeys(events.payload);

Check warning on line 85 in apps/api/src/app/workflows-v2/usecases/create-variables-object/create-variables-object.usecase.ts

View workflow job for this annotation

GitHub Actions / Spell check

Unknown word (Afterpayload)
}

if (hasUsedEventCount || hasUsedEventsLength || hasUsedEvents || hasUsedEventsWithPayload) {
step.events = Array.isArray(events)
? events
: Array.from({ length: DEFAULT_ARRAY_ELEMENTS }, (_, index) => {
return {
payload: { name: `event-${index}` },
};
let payload = {};
for (const variableName of variableNameAfterpayload) {
payload = { ...payload, ...this.setNestedValue(payload, variableName, `event-${index}`) };
}

return { payload };
});
}
});

return variablesObject;
}

private setNestedValue(obj: Record<string, unknown>, path: string, value: string) {
const keys = path.split('.');

const val = keys.reduceRight((acc, key, index) => {
if (index === keys.length - 1) {
return { [key]: value };
} else {
return { [key]: acc };
}
}, {});

return lodash.merge(obj, val);
}

private async getControlValues(command: CreateVariablesObjectCommand) {
if (command.controlValues) {
return [command.controlValues].flat().flatMap((obj) => Object.values(obj));
Expand Down
7 changes: 3 additions & 4 deletions apps/api/src/app/workflows-v2/util/build-variables.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import _ from 'lodash';
import { AdditionalOperation, RulesLogic } from 'json-logic-js';
import { PinoLogger } from '@novu/application-generic';
import { AdditionalOperation, RulesLogic } from 'json-logic-js';

import { extractLiquidTemplateVariables, TemplateVariables } from './template-parser/liquid-parser';
import { WrapMailyInLiquidUseCase } from '../../environments-v1/usecases/output-renderers/maily-to-liquid/wrap-maily-in-liquid.usecase';
import { isStringifiedMailyJSONContent } from '../../environments-v1/usecases/output-renderers/maily-to-liquid/wrap-maily-in-liquid.command';
import { WrapMailyInLiquidUseCase } from '../../environments-v1/usecases/output-renderers/maily-to-liquid/wrap-maily-in-liquid.usecase';
import { extractFieldsFromRules, isValidRule } from '../../shared/services/query-parser/query-parser.service';
import { JSONSchemaDto } from '../dtos';
import { extractLiquidTemplateVariables, TemplateVariables } from './template-parser/liquid-parser';

export function buildVariables(
variableSchema: JSONSchemaDto | undefined,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { Filter, Liquid, LiquidError, Output, RenderError, Template, TokenKind } from 'liquidjs';
import { FILTER_VALIDATORS, LiquidFilterIssue } from '@novu/framework/internal';
import { JSONSchemaDto } from '../../dtos';

import { Filter, Liquid, LiquidError, Output, RenderError, Template, TokenKind } from 'liquidjs';
import { extractLiquidExpressions, isValidTemplate } from './parser-utils';
import { JSONSchemaDto } from '../../dtos';

const LIQUID_CONFIG = {
strictVariables: true,
Expand Down Expand Up @@ -245,6 +246,27 @@ function parseByLiquid({
const isAllowedVariable = isPropertyAllowed(variableSchema, variableName);
if (isAllowedVariable) {
validVariables.push({ name: variableName, output: rawOutput });
if (filters.length > 0) {
filters.forEach((filter) => {
const { args } = filter;
const firstArg = args[0];
if (
filter.name === 'toSentence' &&
args.length > 0 &&
'content' in firstArg &&
typeof firstArg.content === 'string' &&
firstArg.content.startsWith('payload.')
) {
const isFirstArgValid = isPropertyAllowed(variableSchema, firstArg.content);
if (isFirstArgValid) {
validVariables.push({
name: `${variableName}.${firstArg.content}`,
output: `{{${firstArg.content}}}`,
});
}
}
});
}
} else {
invalidVariables.push({
name: variableName,
Expand Down
Loading