-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(dashboard): update sentence summary filter to use payload name #8175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dashboard's digest filter logic and modifies the events object creation in the workflows module to incorporate a payload name.
- Updated the SENTENCE_SUMMARY filter to use a payload property.
- Changed the default events initialization to create objects with a payload name instead of filling with a static string.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/dashboard/src/components/variable/utils/digest-variables.tsx | Updated the sentence summary filter to pass "payload.name" to the toSentence pipe. |
| apps/api/src/app/workflows-v2/usecases/create-variables-object/create-variables-object.usecase.ts | Modified events initialization to construct objects with a payload name using Array.from. |
Comments suppressed due to low confidence (2)
apps/dashboard/src/components/variable/utils/digest-variables.tsx:85
- Verify that passing 'payload.name' as a string literal to toSentence is the intended behavior. If this change affects the extraction of the actual payload name, consider adding a clarifying comment.
[DIGEST_VARIABLES_ENUM.SENTENCE_SUMMARY]: "| toSentence: 'payload.name', 2, 'other',"
apps/api/src/app/workflows-v2/usecases/create-variables-object/create-variables-object.usecase.ts:69
- Ensure that updating events from a string array to an array of objects with a payload name does not break downstream logic expecting event strings.
step.events = Array.isArray(step.events) ? step.events : Array.from({ length: DEFAULT_ARRAY_ELEMENTS }, (_, index) => {
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer