Skip to content

Conversation

tatarco
Copy link
Contributor

@tatarco tatarco commented Apr 22, 2025

What changed? Why was the change needed?

removed a conditional that was skipping count.
refactored cleanup get subscription

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: refactored get subscription so it will all be cached
It should be something like: feat(scope): Add fancy new feature

Details:

No release type found in pull request title "refactored get subscription so it will all be cached". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@netlify
Copy link

netlify bot commented Apr 22, 2025

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 434ff80
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/680a63b504950700086ce18a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant