feat(dashboard): track selection of digest variables in autocomplete #8169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry tracking for digest variable selections in the dashboard's autocomplete features. Key changes include:
- Adding a new telemetry event (DIGEST_VARIABLE_SELECTED) in telemetry utilities.
- Modifying autocomplete source functions in liquid-autocomplete.ts and control-input.tsx to include telemetry tracking via a track callback.
- Integrating telemetry tracking into the MailyVariablesListView component in the email workflow editor.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/dashboard/src/utils/telemetry.ts | Added new telemetry event for digest variable selection |
| apps/dashboard/src/utils/liquid-autocomplete.ts | Updated autocomplete source to track digest variable selections and include a new telemetry callback |
| apps/dashboard/src/components/workflow-editor/steps/email/views/maily-variables-list-view.tsx | Integrated telemetry tracking for digest variable selection upon item selection |
| apps/dashboard/src/components/primitives/control-input/control-input.tsx | Passed telemetry track callback to autocomplete source function |
Comments suppressed due to low confidence (1)
apps/dashboard/src/components/workflow-editor/steps/email/views/maily-variables-list-view.tsx:78
- [nitpick] Consider using a consistent payload key (e.g., 'variable' instead of 'type') for the DIGEST_VARIABLE_SELECTED event to maintain consistency across telemetry calls.
track(TelemetryEvent.DIGEST_VARIABLE_SELECTED, { type: item.name, });
scopsy
reviewed
Apr 21, 2025
Comment on lines
+78
to
+80
| track(TelemetryEvent.DIGEST_VARIABLE_SELECTED, { | ||
| type: item.name, | ||
| }); |
There was a problem hiding this comment.
Is it possible to have a generic "Variable Selected" event and pass the name as a pram?
There was a problem hiding this comment.
Yes, do we want to track all the variables including payload, subscriber etc
or just the digest ones for now?
SokratisVidros
suggested changes
Apr 22, 2025
BiswaViraj
force-pushed
the
nv-5699-analytics
branch
from
d33bf92 to
110c46c
Compare
SokratisVidros
approved these changes
Apr 22, 2025
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer