Skip to content

Conversation

@djabarovgeorge
Copy link
Contributor

@djabarovgeorge djabarovgeorge commented Feb 20, 2025

What changed? Why was the change needed?

  • Create System User
  • Create a mock clerk library
  • Auto generate self-hosted jwt token

docs update

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@netlify
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 2b694ce
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/67b82ccab692160008da4e54
😎 Deploy Preview https://deploy-preview-7755.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit f0439a2
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/681ccc1cdaa89700084dac6a

… and streamline logMeIn method in AuthController, fix clerk mock
- Eliminated unnecessary @ts-expect-error comments in the createExtensions function for better type safety and clarity.
- Removed CommunityEditionService from providers in community.auth.module.config.ts for cleaner module configuration.
- Enhanced link-entities.service.spec.ts by adding LoggerModule for improved logging capabilities during tests.
- Updated session.usecase.ts to include additional condition for maxSnoozeDurationHours based on CI_EE_TEST environment variable.
- Updated the test command in package.json to include NOVU_ENTERPRISE and CLERK_ENABLED environment variables for improved testing context.
- Simplified the logic for maxSnoozeDurationHours in session.usecase.ts by removing the CI_EE_TEST condition, enhancing code clarity.
…unction

- Updated CommunityEditionService and SelfHostUsecase to use getSelfHostedFindQuery for organization retrieval instead of hardcoded COMMUNITY_EDITION_NAME.
- This change improves maintainability and reduces duplication of the organization name logic.
@djabarovgeorge djabarovgeorge merged commit 4aa4244 into next May 8, 2025
30 checks passed
@djabarovgeorge djabarovgeorge deleted the self-hosted-auth branch May 8, 2025 16:26
bricehemery pushed a commit to jack-agency/novu that referenced this pull request Jul 7, 2025
Co-authored-by: Dima Grossman <dima@grossman.io>
Co-authored-by: Himanshu Garg <garg_himanshu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants