-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(dashboard,api-service): add self-hosted-auth #7755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
… and streamline logMeIn method in AuthController, fix clerk mock
…y in SystemOrganizationService
…ed clerk mock file
…ls and remove redundant definition
…an up unused UserButton definition
- Eliminated unnecessary @ts-expect-error comments in the createExtensions function for better type safety and clarity.
- Removed CommunityEditionService from providers in community.auth.module.config.ts for cleaner module configuration. - Enhanced link-entities.service.spec.ts by adding LoggerModule for improved logging capabilities during tests. - Updated session.usecase.ts to include additional condition for maxSnoozeDurationHours based on CI_EE_TEST environment variable.
- Updated the test command in package.json to include NOVU_ENTERPRISE and CLERK_ENABLED environment variables for improved testing context. - Simplified the logic for maxSnoozeDurationHours in session.usecase.ts by removing the CI_EE_TEST condition, enhancing code clarity.
…unction - Updated CommunityEditionService and SelfHostUsecase to use getSelfHostedFindQuery for organization retrieval instead of hardcoded COMMUNITY_EDITION_NAME. - This change improves maintainability and reduces duplication of the organization name logic.
scopsy
approved these changes
May 8, 2025
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
Co-authored-by: Dima Grossman <dima@grossman.io> Co-authored-by: Himanshu Garg <garg_himanshu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
docs update
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer