fix: flaky PollWatcher tests #732
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes tests for a PollWatcher.
I think, the test failed due to races between FS and our code.
It might be the behavior described below
watchthe parentPollWatcherscans the parent and found an initial state of the filedetect_changesread_dirand still find the file in the dir (because the directory info has not been updated yet, probably?)Modifyinstead ofRemoveI added the two helper methods to wait a directory state - sleep while / until a child exists in a
read_dircall results and called them in any suitable situationcloses #731