[Mod Content] basic mod support #201

esphas · 2025-08-24T10:14:18Z

as is said in #36, this PR provides basic mod support

no frontend change except for JsonView.svelte
will fetch all_mods.json only when url param m is specified (m=A,B,C means using mod A, B, C in this order)

check cdda-guide-mod.vercel.app for examples.

~~also check #202 before merging this one~~

EDIT

Given that additional content has been added to this branch, I will now summarize the main changes:

when url param m is present, fetch all_mods.json and load mod content in the specified order (App.svelte, data.ts)
handle monster blacklists and whitelists (data.ts)
added dependency svelecte to provide a dropdown for mod selection, with changes reflected on the page in real time (App.svelte)
when viewing raw JSON, distinguish between different mods (and base game content) (JsonView.svelte)
allow viewing main content added by each mod (App.svelte, ModCategory.svelte)
added ModTag.svelte, which can be used to display the mod override chain (e.g., A > B > C), though it is not currently in use to avoid an excessively long change list

Unresolved issues:

handling of location blacklist (see Preventing locations from spawning

nornagon

looking good, just some minor comments

nornagon · 2025-08-25T15:40:09Z

src/data.ts

+    this._nestedMapgensById.clear();
+
+    for (const obj of this._raw) {
+      obj.__mod = "Dark Days Ahead";


this should probably be the mod id rather than the mod name, and we can map id => name for display

nornagon · 2025-08-25T15:45:03Z

src/data.ts

+      const oldIndex = this._byType
+        .get(mappedType)!
+        .findIndex((x) => x.id === obj.id);
+      if (oldIndex !== -1) {
+        const oldObj = this._byType.get(mappedType)![oldIndex];


Suggested change

const oldIndex = this._byType

.get(mappedType)!

.findIndex((x) => x.id === obj.id);

if (oldIndex !== -1) {

const oldObj = this._byType.get(mappedType)![oldIndex];

const oldObj = this._byTypeById

.get(mappedType)!.get(obj.id);

if (oldObj != null) {

nornagon · 2025-08-25T15:45:56Z

src/data.ts

+    return this._rawMods[modId];
+  }
+
+  getEnabledMods(): string[] {


Suggested change

getEnabledMods(): string[] {

get enabledMods(): string[] {

nornagon · 2025-08-25T15:46:03Z

src/data.ts

+    }
+  }
+
+  availableMods(): string[] {


Suggested change

availableMods(): string[] {

get availableMods(): string[] {

nornagon · 2025-08-25T15:46:29Z

src/data.ts

+  modEnabled() {
+    return this._enabledMods.length > 0;


i think this is fine to be inlined at the call sites; no need for a dedicated helper function.

nornagon · 2025-08-25T15:47:25Z

src/types/item/HarvestedFrom.svelte

+      const harvest = data.modEnabled()
+        ? data.byIdMaybe("harvest", h.id)
+        : data.byId("harvest", h.id);
+      if (!harvest) return false;


Suggested change

const harvest = data.modEnabled()

? data.byIdMaybe("harvest", h.id)

: data.byId("harvest", h.id);

if (!harvest) return false;

const harvest = data.byIdMaybe("harvest", h.id);

if (!harvest) return false;

i think it's ok not to throw an error here when this isn't found, even if there are no mods enabled.

nornagon · 2025-08-25T15:48:31Z

src/JsonView.svelte

+function allSources(o: any): any[] {
+  const sources: any[] = [];
+  sources.push(o.__self);
+  while (o.__prevSelf) {
+    sources.push(o.__prevSelf);
+    o = o.__prevSelf;
+  }
+  return sources.reverse();
+}


share code with the helper in data.ts?

nornagon · 2025-08-25T15:49:16Z

src/data.ts

+          const group = this.modEnabled()
+            ? this.byIdMaybe("item_group", entry.group)
+            : this.byId("item_group", entry.group);
+          if (!group) continue;


Suggested change

const group = this.modEnabled()

? this.byIdMaybe("item_group", entry.group)

: this.byId("item_group", entry.group);

if (!group) continue;

const group = this.byIdMaybe("item_group", entry.group);

if (!group) continue;

nornagon · 2025-08-25T15:49:45Z

src/data.ts

+          const group = this.modEnabled()
+            ? this.byIdMaybe("item_group", entry.group)
+            : this.byId("item_group", entry.group);
+          if (!group) continue;


Suggested change

const group = this.modEnabled()

? this.byIdMaybe("item_group", entry.group)

: this.byId("item_group", entry.group);

if (!group) continue;

const group = this.byIdMaybe("item_group", entry.group);

if (!group) continue;

nornagon · 2025-08-25T15:51:41Z

src/data.ts

+    }
+
+    let parent: any = null;
+    if (obj.__prevSelf != null) {


just realised that this means we show the copy-from links in the UI even for non-mod items. that's a nice little upgrade!

esphas · 2025-08-26T02:15:08Z

some of the issues you mentioned were actually already addressed in #202, which I just closed since it became too large and complex.
I’ll spend some time breaking down those improvements and submitting them here in a more manageable way.

esphas · 2025-08-26T13:58:13Z

that's all for now. I'm done adding new features to this PR, and any future commits will just be for bug fixes or tidying up.

j66493341

HS free fire

nornagon · 2025-09-06T23:04:14Z

I've been working on top of this branch to tweak stuff a bit. I didn't like the Svelecte component, so I embarked on a rework of the mod selection UI. Take a look at the branch nornagon/mod-tweaks. I couldn't figure out how to make GitHub display a diff from the base to the fork, but you should be able to at least check out the branch locally...

Not quite done yet but just so you know, here are some general principles I've been working by (but never wrote down...)

<section> never has another <section> inside it.
Avoid dependencies if possible. At runtime we basically only depend on fuzzysort, gettext.js, lodash/throttle and transifex. I like to keep this list minimal.

I'm also violating a 3rd principle, which is that the only things that are interactable are links—the checkboxes in the mod catalog aren't links—so I'll think about if I'm ok with that.

esphas · 2025-09-12T07:41:17Z

I've been working on top of this branch to tweak stuff a bit. I didn't like the Svelecte component, so I embarked on a rework of the mod selection UI. Take a look at the branch nornagon/mod-tweaks. I couldn't figure out how to make GitHub display a diff from the base to the fork, but you should be able to at least check out the branch locally...

Not quite done yet but just so you know, here are some general principles I've been working by (but never wrote down...)
1. <section> never has another <section> inside it.

2. Avoid dependencies if possible. At runtime we basically only depend on fuzzysort, gettext.js, lodash/throttle and transifex. I like to keep this list minimal.
I'm also violating a 3rd principle, which is that the only things that are interactable are links—the checkboxes in the mod catalog aren't links—so I'll think about if I'm ok with that.

thanks for the update and for writing down those principles.
I'm pretty swamped recently, so I won't be able to dive into the branch right away, but I'll check it out as soon as things calm down on my end.

o mods enabled hint

esphas · 2025-09-17T06:15:20Z

@nornagon I just pulled your latest changes from the mod-tweaks branch - looks clean and clear to me. I've merged it into this branch and made a few cleanups:

removed svelecte dependency and related styles
removed the redundant "Mods" link (since we now have it in the footer)
add a "No mods enabled" hint text.

nothing more from my side for now.

esphas added 8 commits August 18, 2025 23:26

mod support

9a24641

mod support

643c02f

fix

8541a26

fix

abf42fa

CDDA_DATA_SOURCE

a1dc9ae

fix

a60617c

load mods only when base json have modlist

d45f7e3

fix technique json view

37eccac

This was referenced Aug 24, 2025

[Mod Content] mod support #202

Closed

[FEATURE REQUEST] Mod content #36

Open

nornagon mentioned this pull request Aug 25, 2025

Feature Request: Support content lookup for popular mods (Magiclysm & Mind Over Matter) #204

Closed

nornagon reviewed Aug 25, 2025

View reviewed changes

esphas added 9 commits August 26, 2025 10:21

Merge remote-tracking branch 'upstream/main'

5dbc4e1

catchup

553b0a3

use svelecte for selecting mods

439771f

styling

e60ec6b

styling

d5e5b31

cleanup

d4c4556

catchup

9ff5bf7

catchup

d0639cc

fix getAllObjectSources for some json_flags

9638ba2

j66493341 approved these changes Sep 3, 2025

View reviewed changes

tweak mod selector, catalog changes

5a6db5c

esphas added 2 commits September 17, 2025 13:39

remove svelecte

8e63e22

remove redundant Mods link; add

2f0ff8c

o mods enabled hint

Uh oh!

[Mod Content] basic mod support #201

Are you sure you want to change the base?

[Mod Content] basic mod support #201

Uh oh!

Conversation

esphas commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nornagon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

esphas commented Aug 26, 2025

Uh oh!

esphas commented Aug 26, 2025

Uh oh!

j66493341 left a comment

Choose a reason for hiding this comment

Uh oh!

nornagon commented Sep 6, 2025

Uh oh!

esphas commented Sep 12, 2025

Uh oh!

esphas commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

esphas commented Aug 24, 2025 •

edited

Loading