Skip to content

NC | 5.18.4 backports #9027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 21, 2025
Merged

NC | 5.18.4 backports #9027

merged 25 commits into from
May 21, 2025

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented May 15, 2025 •
edited
Loading

Describe the Problem

Backports of NC lifecycle and glacier reserved bucket tagging.

Explain the Changes

The following PRs are being backported to 5.18 -

  1. NC | lifecycle | fix notifications #8913
  2. NC | lifecycle | continue last run #8925
  3. NC | Lifecycle | Convert NCLifecycle to a class #8929
  4. NC | CLI | InvalidType Error | Replaced hard coded command types list with a dynamic list #8952
  5. File Reader | Add next_line_file_offset #8953
  6. Added required validations in lifecycle rules #8914 (contains 2 commits)
  7. NC | CI | fix lifecycle timeout flaky test #8971
  8. NC | Lifecycle | GPFS ILM integration #8923
  9. NC | lifecycle | add newer noncurrent versions rule #8949
  10. NC | lifecycle | add expire delete marker rule #8961
  11. NC | Add non current timestamp xattr support #8975
  12. NC | lifecycle | Add Tests in POSIX Integration Tests - Part 1 #8990
  13. NC | lifecycle | Add Tests in POSIX Integration Tests - Part 2 #8994
  14. NC | Delete object filter verification on regular delete object  #8950
  15. NC | Lifecycle | Adjust expire/noncurrent state properties to GPFS flow + fix of 2 small bugs #8999
  16. NC | lifecycle | add noncurrent days rule #8992
  17. NC | lifecycle | Add Tests in POSIX Integration Tests - Part 3 #9001
  18. NC | lifecycle | remove key_marker and version_marker from state when finished #8991
  19. NC | lifecycle | Small GPFS flow fixes #9006
  20. NC | lifecycle | fix expire-delete-marker issues #9008
  21. NC | lifecycle | _parse_key_from_line remove redundant / at the beginning of the file key #9022
  22. [NC | DBS3] Add support for reserved bucket tags #8967
  23. Manual util function addition - 3685927.
  24. Added a fix for bucket lifecycle having tagging as an empty array in filter #8940

Conflicts resolution notes -

Backport Jira Ticket - https://issues.redhat.com/browse/DFBUGS-2510

@romayalon romayalon force-pushed the romy-5.18-backports branch from 3685927 to b99ca7d Compare May 15, 2025 16:26
nadavMiz and others added 25 commits May 18, 2025 11:27
@nadavMiz @romayalon
NC | lifecycle | fix notifications
9403388 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit 10e1156)
@nadavMiz @romayalon
NC | lifecycle | continue last run
5bd5e55 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit 73edf4c)
@romayalon
NC | Lifecycle | Convert NCLifecycle to a class
58d1fad 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 1148a8b)
@achouhan09 @romayalon
Added a fix for bucket lifecycle - if tagging is an empty array in fi…
3f85532 
…lter

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
(cherry picked from commit 256f157)
@romayalon
NC | replace invalid type error hard coded command types list with a …
cbf30b9 
…dynamic list

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 118e6c0)
@romayalon
File Reader | Add line_bytes_offset
6d833de 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 2116887)
@achouhan09 @romayalon
1. Added required validations in lifecycle rules for filter, expirati…
1c79aa0 
…on and AboutIncompleteMultipartUpload

2. Added tests for the above validations

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
(cherry picked from commit 0c49cb6)
@achouhan09 @romayalon
Removed the ceph s3 faulty test - test_lifecycle_expiration_tags1
3d6baec 
Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
(cherry picked from commit de96bdd)
@romayalon
NC | CI | fix lifecycle timeout flaky test
da6a6ed 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 97c6e11)
@romayalon
NC | Lifecycle | GPFS ILM policies integration
529ba07 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 20db54f)
@nadavMiz @romayalon
NC | lifecycle | add newer noncurrent versions rule
86d4bf2 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit 800a847)
@nadavMiz @romayalon
NC | add expire delete marker rule
254cdb0 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit f216a3b)
@romayalon
NC | Add non current timestamp xattr support
3da3318 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit a0df317)
@shirady @romayalon
NC | lifecycle | Add Tests in POSIX Integration Tests
83ac850 
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
(cherry picked from commit cda59e5)
@shirady @romayalon
NC | lifecycle | Add Tests in POSIX Integration Tests - Part 2
4c45373 
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
(cherry picked from commit f568bb1)
@romayalon
NC | delete object filter verification on regular delete object (dele…
e007e91 
…te marker and version id deletion is not implemented yet)

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 2c7d076)
@romayalon
NC | Lifecycle | Adjust expire/noncurrent state properties to GPFS flow
5f5ac13 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit b66acc0)
@nadavMiz @romayalon
NC | lifecycle | add noncurrent days rule
9c76222 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit 5f9af01)
@shirady @romayalon
NC | lifecycle | Add Tests in POSIX Integration Tests - Part 3
3920d7d 
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
(cherry picked from commit d5d5258)
@nadavMiz @romayalon
NC | lifecycle | remove key_marker and version_marker from state when…
d0ab1b0 
… finished

Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit 909a37c)
@romayalon
NC | lifecycle | small GPFS flow fixes
be5640e 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit d591e41)
@nadavMiz @romayalon
NC | lifecycle | fix expire-delete-marker issues
61e1c70 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
(cherry picked from commit bd80fa7)
@romayalon
NC | _parse_key_from_line remove redundant / at the beginning of the …
7d2d445 
…file key

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
(cherry picked from commit 4970b45)
@tangledbytes @romayalon
add support for reserved bucket tags
e1658ce 
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

fix put_bucket_tagging test - pass dummy objectsdk

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

add support for events, race safe tag manipulation and --merge_tag flag

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

fix lint issues

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

clarify the reserved tags config comment

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

add docs for the CLI changes

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

address PR comments

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

add account name to the bucket create event

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

address PR comments

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
(cherry picked from commit f400465)
@romayalon
Manual add stat_ignore_enoent() to 5.18.4
a793873 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-5.18-backports branch from b99ca7d to a793873 Compare May 18, 2025 08:27
@romayalon romayalon changed the title NC | 5.18 backports NC | 5.18.4 backports May 18, 2025
@nimrod-becker nimrod-becker merged commit c8e8bd1 into noobaa:5.18 May 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romayalon @nimrod-becker @nadavMiz @achouhan09 @shirady @tangledbytes