Skip to content

LDAP Support - Part 1 #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Apr 20, 2025

Describe the Problem

We want to support authenticating to noobaa services using LDAP user/password for authentication
We will use assume_role_with_web_identity with self self-created JWT token of this structure:

{ 
  user: <user-name>, 
  password: <password> , 
  type: "ldap" 
}

signed by a jwt-secret saved under /etc/noobaa-server/ldap-config. looking like this:

{
  "uri": "ldap://192.168.105.16:636",
  "admin": "cn=admin,dc=planetexpress,dc=com",
  "secret": "GoodNewsEveryone",
  "search_dn": "ou=people,dc=planetexpress,dc=com",
  "dn_attribute": "uid",
  "search_base": "dc=example,dc=com",
  "search_scope": "sub",
  **"jwt_secret": "abcdefgh12345678"**
}

Explain the Changes

  1. ldap_client
  2. support assume_role_with_web_identity

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo requested a review from guymguym April 20, 2025 15:09
@jackyalbo jackyalbo force-pushed the jacky_ldap1 branch 2 times, most recently from 822c72b to 1dbfe16 Compare April 21, 2025 13:15
1. ldap_client
2. support assume_role_with_web_identity

Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@@ -97,6 +97,7 @@
"jsonwebtoken": "9.0.2",
"linux-blockutils": "0.2.0",
"lodash": "4.17.21",
"ldapts": "7.3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering using openldap natively instead of adding this dependency. We should at least evaluate the effort to implement and maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants