Skip to content

Fix: 修复在 Windows 平台下未使用 UTF-8 编码读取模块信息的问题 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Fix: 修复在 Windows 平台下未使用 UTF-8 编码读取模块信息的问题 #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nb_cli/handlers/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,15 @@ async def dump_unpublished_modules(module_class: type[T], newer: list[T]) -> Non
module_name: str = module_class.__module_name__

if (path_current := CACHE_DIR / f"{module_name}.json").is_file():
async with await anyio.open_file(path_current) as fcurrent:
async with await anyio.open_file(path_current, encoding="utf-8") as fcurrent:
current = type_validate_json(list[module_class], await fcurrent.read())
else:
current: list[T] = []

if (path_historical := CACHE_DIR / f"{module_name}_unpublished.json").is_file():
async with await anyio.open_file(path_historical) as fhistorical:
async with await anyio.open_file(
path_historical, encoding="utf-8"
) as fhistorical:
historical = type_validate_json(
list[module_class], await fhistorical.read()
)
Expand Down