feat: allow rescaling videos when normalizing, stop normalizing audio #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drake-nominal
commented
Jun 11, 2025
drake-nominal
commented
- rescaling video based on either predefined resolutions, or custom resolutions
- stop adding / checking for presence of audio tracks, as this is now handled by the backend
drake-nominal
commented
Jun 11, 2025
alkasm
reviewed
Jun 11, 2025
alkasm
approved these changes
Jun 11, 2025
ritwikdixit
reviewed
Jun 11, 2025
ritwikdixit
approved these changes
Jun 11, 2025
drake-nominal
force-pushed
the
deidukas/allow-normalizing-resolution-video
branch
from
a58b32d to
e096edf
Compare
stefanv
approved these changes
Jun 11, 2025
Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.