Skip to content

fix: remove compute expression representations from checklists #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nominal-client
Submodule nominal-client added at 58981a
6 changes: 0 additions & 6 deletions nominal/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
Asset,
Attachment,
Channel,
Check,
Checklist,
ChecklistBuilder,
CheckViolation,
Connection,
DataReview,
Expand All @@ -23,7 +21,6 @@
WriteStream,
)
from nominal.nominal import (
checklist_builder,
create_asset,
create_log_set,
create_run,
Expand Down Expand Up @@ -61,7 +58,6 @@
"create_asset",
"create_run",
"create_run_csv",
"checklist_builder",
"download_attachment",
"get_attachment",
"create_streaming_connection",
Expand Down Expand Up @@ -93,9 +89,7 @@
"Asset",
"Attachment",
"Channel",
"Check",
"Checklist",
"ChecklistBuilder",
"Connection",
"Dataset",
"NominalClient",
Expand Down
4 changes: 1 addition & 3 deletions nominal/core/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from nominal.core.asset import Asset
from nominal.core.attachment import Attachment
from nominal.core.channel import Channel
from nominal.core.checklist import Check, Checklist, ChecklistBuilder
from nominal.core.checklist import Checklist
from nominal.core.client import NominalClient
from nominal.core.connection import Connection
from nominal.core.data_review import CheckViolation, DataReview, DataReviewBuilder
Expand All @@ -18,9 +18,7 @@
"Asset",
"Attachment",
"Channel",
"Check",
"Checklist",
"ChecklistBuilder",
"Connection",
"Dataset",
"FileType",
Expand Down
3 changes: 0 additions & 3 deletions nominal/core/_clientsbunch.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
scout_checklistexecution_api,
scout_checks_api,
scout_compute_api,
scout_compute_representation_api,
scout_dataexport_api,
scout_datareview_api,
scout_datasource,
Expand Down Expand Up @@ -114,7 +113,6 @@ class ClientsBunch:
authentication: authentication_api.AuthenticationServiceV2
catalog: scout_catalog.CatalogService
checklist: scout_checks_api.ChecklistService
compute_representation: scout_compute_representation_api.ComputeRepresentationService
connection: scout_datasource_connection.ConnectionService
dataexport: scout_dataexport_api.DataExportService
datasource: scout_datasource.DataSourceService
Expand Down Expand Up @@ -145,7 +143,6 @@ def from_config(cls, cfg: ServiceConfiguration, agent: str, token: str) -> Self:
authentication=client_factory(authentication_api.AuthenticationServiceV2),
catalog=client_factory(scout_catalog.CatalogService),
checklist=client_factory(scout_checks_api.ChecklistService),
compute_representation=client_factory(scout_compute_representation_api.ComputeRepresentationService),
connection=client_factory(scout_datasource_connection.ConnectionService),
dataexport=client_factory(scout_dataexport_api.DataExportService),
datasource=client_factory(scout_datasource.DataSourceService),
Expand Down
Loading
Loading