feat: simplify dev experience for uploading videos #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drake-nominal
force-pushed
the
deidukas/simpler-video-dx
branch
from
135c91d to
a319fad
Compare
drake-nominal
force-pushed
the
deidukas/simpler-video-dx
branch
from
a319fad to
a692047
Compare
mariobuikhuizen
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of users needing to create datasets from IO for parquet / video, we bring these formats up to par with csv support by adding methods to add the files without users needing to mess around with mimetypes (FileType) & opening files themselves.
Because parquet is specifically not a csv file, I kept
create_csv_datasetfor back-compatibility, but delegate the work to the newcreate_tabular_dataset. Not completely sold on this naming so open to suggestions. Similar decisions occur within the dataset class for appending to a dataset.