Skip to content

feat: make FileType(s) public #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 3, 2024
Merged

feat: make FileType(s) public #158

merged 5 commits into from
Dec 3, 2024

Conversation

alkasm
Copy link
Contributor

@alkasm alkasm commented Dec 3, 2024

Move FileType and FileTypes from nominal._utils to nominal.core. To preserve backcompat for a time, a custom module __getattr__ provides the types at the old path with a deprecation warning:

>>> from nominal._utils import FileTypes
<stdin>:1: UserWarning: nominal._utils.FileTypes is deprecated and will be removed in a future version, use nominal.core.FileTypes instead.
>>> from nominal._utils import FileType
<stdin>:1: UserWarning: nominal._utils.FileType is deprecated and will be removed in a future version, use nominal.core.FileType instead.

@alkasm alkasm merged commit 2358570 into main Dec 3, 2024
6 checks passed
@alkasm alkasm deleted the alkasm/public-filetype branch December 3, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant