-
Notifications
You must be signed in to change notification settings - Fork 1
fix: issues of post merge review of #106 #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
64bb296
fix: streaming connection is not stopping on CTRL-C
mariobuikhuizen 3867d9a
remove nominal from method and class name
mariobuikhuizen df68c33
don't do significant work in an initializer
mariobuikhuizen 4e667ee
let timeout thread wait interuptable
mariobuikhuizen a441f5d
add backpressure
mariobuikhuizen 38c5893
fix critical sections of flush
mariobuikhuizen 313a241
use dict instead of Dict
mariobuikhuizen de56df6
use typefull duration for max_wait
mariobuikhuizen ed6a214
Merge branch 'main' into fix_stream_not_stopping
mariobuikhuizen dc4ca00
address issues from review
mariobuikhuizen 4d50df7
fix: use reentrant lock now that lock is used in flush()
mariobuikhuizen cf86116
Merge branch 'main' into fix_stream_not_stopping
mariobuikhuizen caa8810
use frozen dataclass
mariobuikhuizen b53efaf
add deprecation warning for NominalWriteStream
mariobuikhuizen f4ecaf3
Merge branch 'main' into fix_stream_not_stopping
jackparmer b8d80b3
Merge branch 'main' into fix_stream_not_stopping
mariobuikhuizen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.