Skip to content

hotfix: [sdk] Multifile dataset urlsafe #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2024
Merged

hotfix: [sdk] Multifile dataset urlsafe #15

merged 3 commits into from
Sep 5, 2024

Conversation

alkasm
Copy link
Contributor

@alkasm alkasm commented Sep 5, 2024

  • make the filename urlsafe in add_to_dataset_from_io as well
  • use urllib.parse rather than base64 encoding the filename

@alkasm alkasm requested a review from alxhill September 5, 2024 01:39
@alkasm alkasm merged commit 0455f85 into main Sep 5, 2024
1 check passed
@alkasm alkasm deleted the alkasm/multifile-dataset-urlsafe-fix branch September 5, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxhill alxhill Awaiting requested review from alxhill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alkasm