feat: adding ability to specify time column in TDMS groups #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally with representative TDMS; will need to come back and add unit tests. |
sslattery2
changed the title
alkasm
reviewed
Nov 21, 2024
alkasm
reviewed
Nov 22, 2024
alkasm
approved these changes
Nov 25, 2024
- move to separate file - move filtering logic to separate functions - use reduce to merge dataframes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of upload_tdms() only allowed for waveform data where the time interval property had been set. Not all users use waveforms, regular time series data may just have a time column (a la CSV). This PR adds optional args to upload_tdms() for time column name and type.