Skip to content

fix: bucket workaround not correct for current backend #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: bucket workaround not correct for current backend #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1d14d
fix: bucket workaround not correct for current backend
mariobuikhuizen Nov 21, 2024
92cfa1b
Merge branch 'main' into fix_remove_bucket_workaround
mariobuikhuizen Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions nominal/core/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ def get_decimated(
if buckets is not None and resolution is not None:
raise ValueError("Either buckets or resolution should be provided")

if buckets is not None:
# Somehow the number of points returned is buckets / 1000
buckets = buckets * 1000

result = self._decimate_request(start, end, buckets, resolution)

# when there are less than 1000 points, the result is numeric
Expand Down
Loading