Skip to content

Conversation

Kristinita
Copy link

1. Summary

I minify index.js and gemini-scrollbar.css.

2. Argumentation

3. Environment

I minify files use default settings of this minifiers:

Thanks.

Use cssnano and Uglify JS
@Kristinita
Copy link
Author

@noeldelgado , ping.

Thanks.

@Kristinita
Copy link
Author

Type: Additional arguments

@noeldelgado, I’m not sure, that ignoring pull requests is the best strategy.

CDN

Yes, jsDelivr can automatically minify files. Example — https://cdn.jsdelivr.net/npm/gemini-scrollbar@1.5.3/index.min.js. But:

  1. Other services may not automatically minify files.

  2. See the comment of jsDelivr founder:

    Yes, we do minify manually some files but the difference is that we can check for validity. The bot cant do that, it will simply upload the output of the tool.

    And we still prefer to ask the authors to include official minified files to remove all responsibility from us.

    Ideally we want to enable auto-updates on all projects and have all authors include minified files.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant