Skip to content

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 24, 2025

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak Uzlopak requested a review from Copilot September 24, 2025 07:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the test framework by replacing the third-party tspl library with Node.js's built-in test context (testcontext). The change standardizes mock test assertions to use the native Node.js test API.

  • Removes dependency on @matteo.collina/tspl library
  • Updates all test assertions to use t.assert.* pattern instead of direct t.* calls
  • Removes manual test planning and ending calls that are now handled automatically

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/mock-utils.js Converts tspl usage to native test assertions for mock utility functions
test/mock-scope.js Updates MockScope test assertions to use t.assert API
test/mock-pool.js Migrates MockPool tests from tspl to native Node.js test context
test/mock-interceptor.js Converts MockInterceptor test assertions and removes manual test lifecycle management
test/mock-interceptor-unused-assertions.js Updates pending interceptor assertion tests to use native API
test/mock-errors.js Migrates mock error tests to use t.assert pattern
test/mock-client.js Converts MockClient tests from tspl to native test assertions
test/mock-call-history.js Updates call history test assertions and removes t.end() calls
test/mock-call-history-log.js Migrates call history log tests to native Node.js test API
test/mock-agent.js Large conversion of MockAgent tests from tspl to t.assert pattern
Comments suppressed due to low confidence (1)

test/mock-agent.js:1

  • Missing await keyword before t.assert.rejects call. This should be await t.assert.rejects(...) to properly handle the async assertion.
'use strict'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant