Skip to content

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 24, 2025

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak Uzlopak requested a review from Copilot September 24, 2025 07:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors cookie test files to use the test context parameter (t) instead of importing individual assertion functions from node:assert. The purpose is to standardize the test structure to use t.assert.* methods throughout the cookie testing suite.

  • Removes node:assert imports from cookie test files
  • Updates all assertion calls to use the test context parameter (t.assert.*)
  • Maintains the same test logic while following consistent patterns

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/cookie/validate-cookie-value.js Updates assertions to use test context, removes assert import
test/cookie/validate-cookie-path.js Updates assertions to use test context, removes assert import
test/cookie/validate-cookie-name.js Updates assertions to use test context, removes assert import
test/cookie/to-imf-date.js Updates assertions to use test context, removes assert import
test/cookie/npm-cookie.js Updates assertions to use test context, removes assert import, converts function declarations to arrow functions
test/cookie/is-ctl-excluding-htab.js Updates assertions to use test context, removes assert import
test/cookie/global-headers.js Updates assertions to use test context, removes assert import, fixes test structure
test/cookie/cookies.js Updates assertions to use test context, removes assert import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

value: 'Headers',
configurable: true
})
test('Headers check is not too lax', { skip: !globalThis.Headers }, (t) => {
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This should be wrapped in a separate describe block or use test instead of being nested directly within the existing describe block. The original structure had this as a separate describe block.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant