crypto: fix argument validation in crypto.timingSafeEqual fast path #60538
+55
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression introduced by nodejs@0136bb0 made it possible for the fast path to be hit with non-array-buffer arguments despite that the fast paths could only deal with array buffer arguments, so that it can crash with invalid arguments once crypto.timingSafeEqual is optimized instead of throwing validation errors as usual. This adds validation to the fast path so that it throws correctly.
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60538 +/- ##
==========================================
+ Coverage 88.05% 88.54% +0.49%
==========================================
Files 704 704
Lines 207857 207847 -10
Branches 39964 40039 +75
==========================================
+ Hits 183030 184045 +1015
+ Misses 16806 15837 -969
+ Partials 8021 7965 -56
🚀 New features to boost your workflow:
|
ChALkeR
approved these changes
Nov 2, 2025
|
Does the fast path for |
RafaelGSS
approved these changes
Nov 2, 2025
My guess is no, because of the handle scope overhead. |
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Nov 3, 2025
RafaelGSS
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in c9578dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression introduced by
0136bb0 made it possible for the fast path to be hit with non-array-buffer arguments despite that the fast paths could only deal with array buffer arguments, so that it can crash with invalid arguments once crypto.timingSafeEqual is optimized instead of throwing validation errors as usual. This adds validation to the fast path so that it throws correctly.
Originally opened in the private repo to stay on the safe side, moving it to public since there's consensus that this is a regular bug, not a vulnerability.
Refs: https://github.com/nodejs-private/node-private/pull/749
Fixes: #60537