Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of icu to 78.1.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. icu Issues and PRs related to the ICU dependency. test Issues and PRs related to the tests. labels Nov 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@targos
Copy link
Member

targos commented Nov 1, 2025

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (24bebd0) to head (5afe4cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60523      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         704      704              
  Lines      207843   207843              
  Branches    40038    40043       +5     
==========================================
- Hits       184046   184034      -12     
+ Misses      15844    15841       -3     
- Partials     7953     7968      +15     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau
Copy link
Member

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

FWIW it looks like a change when DST is not in effect (no longer outputs Greenwich Mean time):

> process.env.TZ='Europe/Dublin'
'Europe/Dublin'
> new Date('2025/10/01').toLocaleString('en-US', { timeZoneName: 'long' })
'10/1/2025, 12:00:00 AM Irish Standard Time'
> new Date('2025/11/01').toLocaleString('en-US', { timeZoneName: 'long' })
'11/1/2025, 12:00:00 AM GMT+00:00'
>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants