-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
deps: update icu to 78.1 #60523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
deps: update icu to 78.1 #60523
Conversation
|
Review requested:
|
|
/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60523 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01%
==========================================
Files 704 704
Lines 207843 207843
Branches 40038 40043 +5
==========================================
- Hits 184046 184034 -12
+ Misses 15844 15841 -3
- Partials 7953 7968 +15 🚀 New features to boost your workflow:
|
baeca56 to
ebd8b44
Compare
FWIW it looks like a change when DST is not in effect (no longer outputs > process.env.TZ='Europe/Dublin'
'Europe/Dublin'
> new Date('2025/10/01').toLocaleString('en-US', { timeZoneName: 'long' })
'10/1/2025, 12:00:00 AM Irish Standard Time'
> new Date('2025/11/01').toLocaleString('en-US', { timeZoneName: 'long' })
'11/1/2025, 12:00:00 AM GMT+00:00'
> |
This is an automated update of icu to 78.1.