-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
net: do not add multiple connect and finish listeners when multiple Socket.destroySoon's were scheduled
#60469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arturgawlik
wants to merge
16
commits into
nodejs:main
Choose a base branch
from
arturgawlik:do-not-leak-when-destroying-socket-multiple-times
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−2
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6e33069
net: do not duplicate `connect` and `finish` listners on `destroySoon`
arturgawlik 9905cfb
unit test for not duplicating event listeners
arturgawlik afe8307
add messages to test assertions
arturgawlik 565e2c2
use `assert.strictEqual` instead of `assert.equal`
arturgawlik 94edac0
require `common` module
arturgawlik e5ec2a4
remove third argument on `strictEqual` call
arturgawlik ae5739e
use `addresses.INVALID_HOST` in test
arturgawlik a70ef63
`return` from `_final` when `connecting` even if no listeners added
arturgawlik a63fb37
rework test to better reproduce mentioned issue
arturgawlik 40ef455
revert changes in `_final`
arturgawlik c2e85a0
make `destroySoon` noop after first call
arturgawlik 3d238a0
remove unwanted brackets
arturgawlik 81ac752
remove unwanted formatting changes
arturgawlik f703403
Update test/parallel/test-net-socket-not-duplicates-destroy-soon-list…
arturgawlik 7b5a01a
Update test/parallel/test-net-socket-not-duplicates-destroy-soon-list…
arturgawlik c9a2c5e
use symbol for storing `destroyingOnFinish` flag
arturgawlik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
test/parallel/test-net-socket-not-duplicates-destroy-soon-listeners.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| 'use strict'; | ||
| require('../common'); | ||
| const { addresses } = require('../common/internet'); | ||
arturgawlik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| const assert = require('assert'); | ||
| const { Socket } = require('net'); | ||
|
|
||
| const socket = new Socket(); | ||
| socket.on('error', () => { | ||
| // noop | ||
| }); | ||
| socket.connect({ host: addresses.INVALID_HOST, port: 1234 }); | ||
arturgawlik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| socket.destroySoon(); | ||
| socket.destroySoon(); | ||
| assert.strictEqual(socket.listeners('finish').length, 1); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use a
Symbolfor thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right 👍
Symbolused ✅