Skip to content

Conversation

@joyeecheung
Copy link
Member

It should remove both the error and the ready event listeners attached when either of them fires, instead of removing only the one whose corresponding event fires, otherwise the other event listener will always get leaked.

It should remove both the error and the ready event listeners
attached when either of them fires, instead of removing only
the one whose corresponding event fires, otherwise the other
event listener will always get leaked.
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Oct 28, 2025
@Luisangelgarciahernandez975-prog

This comment was marked as spam.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (3c8c1ef) to head (ccabb52).
⚠️ Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60464      +/-   ##
==========================================
+ Coverage   88.07%   88.56%   +0.49%     
==========================================
  Files         704      704              
  Lines      207778   208069     +291     
  Branches    39949    40076     +127     
==========================================
+ Hits       182998   184286    +1288     
+ Misses      16791    15819     -972     
+ Partials     7989     7964      -25     
Files with missing lines Coverage Δ
lib/internal/debugger/inspect_client.js 87.53% <100.00%> (-0.11%) ⬇️

... and 131 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2025
@nodejs-github-bot
Copy link
Collaborator

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants