-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
debugger: fix event listener leak in the run command #60464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joyeecheung
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
joyeecheung:fix-debugger-leak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should remove both the error and the ready event listeners attached when either of them fires, instead of removing only the one whose corresponding event fires, otherwise the other event listener will always get leaked.
This comment was marked as spam.
This comment was marked as spam.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60464 +/- ##
==========================================
+ Coverage 88.07% 88.56% +0.49%
==========================================
Files 704 704
Lines 207778 208069 +291
Branches 39949 40076 +127
==========================================
+ Hits 182998 184286 +1288
+ Misses 16791 15819 -972
+ Partials 7989 7964 -25
🚀 New features to boost your workflow:
|
lpinca
approved these changes
Oct 28, 2025
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
legendecas
reviewed
Oct 29, 2025
d8d64ad to
ccabb52
Compare
jasnell
approved these changes
Nov 5, 2025
legendecas
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should remove both the error and the ready event listeners attached when either of them fires, instead of removing only the one whose corresponding event fires, otherwise the other event listener will always get leaked.