remove unreachable conditionals in kFinishClose #60235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
rishabnotfound
changed the title
code === 0n checks in [kFinishClose] method (lib/internal/quic/quic.js:1386-1401). These conditionals were unreachable due to early return, reducing code complexity.
marco-ippolito
approved these changes
Oct 13, 2025
lpinca
approved these changes
Oct 13, 2025
|
How long this might take? |
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60235 +/- ##
==========================================
+ Coverage 88.54% 88.56% +0.02%
==========================================
Files 704 704
Lines 208123 208390 +267
Branches 40006 40056 +50
==========================================
+ Hits 184280 184569 +289
+ Misses 15877 15843 -34
- Partials 7966 7978 +12
🚀 New features to boost your workflow:
|
rishabnotfound
force-pushed
the
main
branch
2 times, most recently
from
d4b8760 to
b38e46e
Compare
|
@marco-ippolito sir if possible can you re-run the workflows pls |
remove unreachable conditional checks in kFinishClose (lib/internal/quic/quic.js:13861401) that were redundant due to an early return, reducing code complexity.
|
it should be mergeable now |
marco-ippolito
approved these changes
Nov 1, 2025
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant
code === 0nchecks in[kFinishClose]method (lib/internal/quic/quic.js:1386-1401). These conditionals were unreachable due to early return, reducing code complexity.