Skip to content

Conversation

coalest
Copy link

@coalest coalest commented Dec 31, 2024

Description

This PR removes the dependency on pry < 0.15.

Reason for PR:

I get this warning after upgrading to Ruby 3.4.1:

versions/3.4.1/lib/ruby/gems/3.4.0/gems/pry-0.14.2/lib/pry/command_state.rb:3: warning: .rbenv/versions/3.4.1/lib/ruby/3.4.0/ostruct.rb was loaded from the standard library, [250/5650]
o longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of pry-0.14.2 to request adding ostruct into its gemspec.
ruby/3.4.1 isn't supported by this pry-doc version

But pry-nav is preventing me from upgrading to pry-0.15 where the issue has been fixed.

@coalest coalest changed the title Upgrade to pry 0.15 Update pry dependency to support pry 0.15 Dec 31, 2024
@kimyu-ng
Copy link

kimyu-ng commented Jan 24, 2025

We need to merge this PR and make a release under v1.0.1

cc @iloveitaly

@iloveitaly
Copy link
Collaborator

Not using ruby anymore, unfortunately. Someone else will have to help with this.

@kimyu-ng
Copy link

Not using ruby anymore, unfortunately. Someone else will have to help with this.

It resolves this issue as well: #44

  1. We just need to merge this PR in
  2. gem build
  3. gem push

Unfortunately, except the maintainer, none of us has such permission to do those things

@kimyu-ng
Copy link

cc @nixme since he has the permission as well

@ssoulless
Copy link

ssoulless commented Feb 28, 2025

@nixme @banister @ConradIrwin @benizi @jasonrclark @ivoanjo @iloveitaly Any of you guys who can give perms or pay attention to this? thanks! 🙏

@ivoanjo
Copy link
Collaborator

ivoanjo commented Feb 28, 2025

Unfortunately I don't have access to do releases, so while I could merge this change in, we'd still need someone else to get it out :/

@iloveitaly
Copy link
Collaborator

@ssoulless I don't have the permissions to grant new users on the repository and unfortunately I don't work with Ruby anymore and can't help out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants