make installer with sudo-only access work and re-enable ssh-ng #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
changed the title
Mic92
commented
Jun 9, 2025
| # Switch to root user by copying authorized_keys. | ||
| if [[ ${isInstaller} == "y" ]] && [[ ${sshUser} != "root" ]]; then | ||
| # Allow copy to fail if authorized_keys does not exist, like if using /etc/ssh/authorized_keys.d/ | ||
| runSsh "${maybeSudo} mkdir -p /root/.ssh; ${maybeSudo} cp ~/.ssh/authorized_keys /root/.ssh || true" |
There was a problem hiding this comment.
This scripts makes the assumption that the ssh key in /root are respected by the sshd and that the root user is allowed to login via ssh.
Now that our nixos installers should have a fixed ssh-ng implementation, it should be safe to re-enable it. On top we now test the use-case of an installer that doesn't need kexec but sudo explicitly.
|
This should also simplify users who want to turn a Linux distribution without root login into a NixOS installer with a script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our nixos installers should have a fixed ssh-ng implementation,
it should be safe to re-enable it.
On top we now test the use-case of an installer that doesn't need kexec
but sudo explicitly.