mkFirefox: add policy to accept added extensions #8009
Draft
+37
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds extensions added via
profiles..extensions.packages to the policy. In consequence, the extensions are added without complaint and don't need to be enabled manually.
Description
While switching browser, I noticed that the current method of installing extensions, does not enable them. This is because the only firefox is allowed to install extensions, and it only provides one way to do so automatically.
As such, I have improved the method of installing extensions by using the intended way by mozilla to do this, without sacrificing reproducibility. This is achieved by "downloading" extensions from the nix store.
NOTE:
This involves @rycee to change his convenient output derivations for firefox modules.
nix fmt .made some unnecessary changes.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example. (not applicable)
Commit messages are formatted like
Maintainers and Involved:
@chayleaf
@onny
@brckd
@kira-bruneau