sqlite: add module #7981
Open
sqlite: add module #7981
+200
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash/fixup the last 2 commits into their relevant commit |
fk29g
force-pushed
the
add-module-sqlite
branch
from
b57e7eb to
46835a4
Compare
khaneliman
reviewed
Oct 14, 2025
Comment on lines
+108
to
+134
| xdg.configFile."sqlite3/sqliterc".text = lib.concatStringsSep "\n" ( | ||
| lib.filter (x: x != "") [ | ||
| (lib.optionalString (cfg.mode != null) ".mode ${cfg.mode}") | ||
| (lib.optionalString ( | ||
| cfg.separator.column != null && cfg.separator.row != null | ||
| ) ".separator \"${cfg.separator.column}\" \"${cfg.separator.row}\"") | ||
| (lib.optionalString ( | ||
| cfg.separator.column != null && cfg.separator.row == null | ||
| ) ".separator \"${cfg.separator.column}\"") | ||
| (lib.optionalString ( | ||
| cfg.separator.column == null && cfg.separator.row != null | ||
| ) ".separator \"${defaultColSeparator}\" \"${cfg.separator.row}\"") | ||
| (lib.optionalString ( | ||
| cfg.prompt.main != null && cfg.prompt.continue != null | ||
| ) ".prompt \"${cfg.prompt.main}\" \"${cfg.prompt.continue}\"") | ||
| (lib.optionalString ( | ||
| cfg.prompt.main != null && cfg.prompt.continue == null | ||
| ) ".prompt \"${cfg.prompt.main}\"") | ||
| (lib.optionalString ( | ||
| cfg.prompt.main == null && cfg.prompt.continue != null | ||
| ) ".prompt \"${defaultPrompt}\" \"${cfg.prompt.continue}\"") | ||
| (lib.optionalString (cfg.extraConfig != "") (cfg.extraConfig)) | ||
| ] | ||
| ); |
There was a problem hiding this comment.
I worry about this being too restrictive and also dismissive of configuration. This contains a lot of conditional logic when it seems like the file is a basic syntax of .<option> key value or something? Maybe we can make/use a generator that allows more freeform configuration?
If not interested in a generator, I think it'd make more sense to create warnings/assertions when combining mutually exclusive options instead of just silently choosing which to apply.
There was a problem hiding this comment.
In any case, it should probably have an escape hatch of some sort. This is not a fancy looking declarative configuration, it's just a script that gets run upon running sqlite. It can include arbitrary SQL in addition to the . commands. It's pretty common to use it to enable foreign key constraints for example.
|
I worry about this being too restrictive and also dismissive of
configuration. This contains a lot of conditional logic
Yeah, I don't really like this part as well. It's just the best I could
come up with with my limited knowledge of the language as I'm still
quite new to nix.
when it seems like the file is a basic syntax of `.<option> key value`
or something?
That's the thing, `sqliterc` is basically just a list of commands to
automatically run when entering a sqlite shell. Specifically, the
separator syntax looks like this:
`.separator <col> <row>` where <col> and <row> are strings
Meaning, to change just the row separator, you'd still need to give a
column separator too, even if you wanted to keep the default one. Same
for the prompt.
I think it'd make more sense to create warnings/assertions when
combining mutually exclusive options instead of just silently choosing
which to apply.
Not sure which mutually exclusive options you're referring to. I don't
think there are any. The awkward conditionals are there because of what
I explained in the previous paragraph.
There's probably a cleaner way to handle this, though. Writing a
generator might be helpful, but I'm not sure where to start looking to
learn how to write one.
|
h7x4
reviewed
Oct 18, 2025
modules/programs/sqlite.nix
Outdated
| options.programs.sqlite = { | ||
| enable = lib.mkEnableOption "sqlite"; | ||
|
|
||
| package = lib.mkPackageOption pkgs "sqlite" { nullable = true; }; |
There was a problem hiding this comment.
Assuming this is intended for interactive use?
Suggested change
| package = lib.mkPackageOption pkgs "sqlite" { nullable = true; }; | |
| package = lib.mkPackageOption pkgs "sqlite-interactive" { | |
| nullable = true; | |
| example = [ "sqlite" ]; | |
| }; |
Add tests for an empty and decently realistic example configuration.
|
Assuming this is intended for interactive use?
It is, yeah. Thanks for the suggestion.
|
fk29g
force-pushed
the
add-module-sqlite
branch
from
46835a4 to
3878dd8
Compare
|
In any case, it should probably have an escape hatch of some sort.
Doesn't it already have that via the `extraConfig` option?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a module for configuring SQLite.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module