modules: add minimal entrypoint to only enable core modules
#7970
+144
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
reviewed
Oct 19, 2025
| ./programs/zsh | ||
| ./programs/ion.nix | ||
| ./programs/nushell.nix | ||
| ./services/window-managers/i3-sway/default.nix # Dependency of home-cursor module |
There was a problem hiding this comment.
This seems like it should be addressed with defensive logic. We should not rely on sway being present for home-cursor logic.
| if minimal then | ||
| [ | ||
| ./programs/bash.nix | ||
| ./programs/autojump.nix # Dependency of bash module |
There was a problem hiding this comment.
Similar here, we shouldn't rely on the autojump module for bash.
|
Agreed on both fronts - I was just trying to get something minimal working. The sway dependency in sway = {
enable = mkEnableOption "sway config generation for {option}`home.pointerCursor`";
};Definitely seems like something we could just move into the Meanwhile, the imports = [
(lib.mkRenamedOptionModule
[ "programs" "bash" "enableAutojump" ]
[
"programs"
"autojump"
"enable"
]
)
];Renamed modules end up unfortunately creating a dependency on the new location. Maybe we could move the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, home-manager imports every single module by default. This leads to performance penalties as the number of modules increases over time (see the relevant nixpkgs issue. For power users who wish to save on eval time, I've added a
minimalentrypoint. This disables almost all modules underprograms/andservices/, so the user can vendor the modules they actually use manually.To make sure this was working, I set it up in my config, and made sure that only the baseModules I specified were included.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.