Skip to content

Conversation

@cdmistman
Copy link
Contributor

for replit/nixmodules i'd like to use fenix to supply the rust toolchains. i'd like to make the name of the nixmodules something like rust-1.73:... but that's not really feasible with fenix.

this pr changes the manifest generation and derivation construction for components.

  • during manifest generation (update script), the version of the component is now included in the JSON object as a field, unedited
    • note: this has an unfortunate side-effect (see screenshot below)
  • when building the component derivation, prefers the version from the component source instead of relying solely on the date of the component or the date the component was fetched
image

@cdmistman
Copy link
Contributor Author

cdmistman commented Oct 5, 2023

fyi @figsoda CI passes when i manually run locally, the reason why it's failing in CI is because the update script needs to be run since it adds a field to the data json files

i can do this first thing in the morning to ensure reproducibility with main

@cdmistman cdmistman changed the base branch from main to staging October 29, 2023 20:18
@eureka-cpu
Copy link
Contributor

Hey @cdmistman, this seems like a reasonable ask. I'm not sure I understand the drawback mentioned, and the screenshot doesn't open in a tab when I try to inspect it so I can't quite tell what you were trying to say. Also would you mind resolving the conflicts on the branch?

@eureka-cpu eureka-cpu added the enhancement New feature or request label Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants