Add option to show stack trace in failed builds #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a |
Erethon
force-pushed
the
feat-show-stack-trace
branch
from
1160de9 to
b530999
Compare
Sorry about that, should have opened as draft until all the checks passed. |
Mic92
reviewed
May 22, 2025
Erethon
force-pushed
the
feat-show-stack-trace
branch
from
b530999 to
4bae315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option called
showTracethat adds--show-traceon nix builds and evals to show the full stack trace when something fails. It's off by default to keep the existing functionality as is.You can see it in action here.
I'm not that familiar with the buildbot(-nix) codebase, so I hope I haven't missed something obvious in this change.