Update install.md #830
Open
Update install.md #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note to set password before deploying new configuration, closes nix-community#829
docs/src/install.md
Outdated
| sudo nix-channel --update | ||
| ``` | ||
|
|
||
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. |
There was a problem hiding this comment.
Suggested change
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. | |
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set `security.sudo.wheelNeedsPassword = true;` which is the default. |
There was a problem hiding this comment.
Pull Request Overview
Adds a safety note to the installation docs reminding users to set their password before enabling sudo password requirements (closes #829).
- Adds a reminder about setting a user password when enabling security.sudo.wheelNeedsPassword
- Minor wording/formatting opportunity in the new sentence for clarity and consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
docs/src/install.md
Outdated
| sudo nix-channel --update | ||
| ``` | ||
|
|
||
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. |
There was a problem hiding this comment.
Grammatical fix: replace 'in case you'll set' with 'in case you set' for correct tense and clarity.
Suggested change
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. | |
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you set ` security.sudo.wheelNeedsPassword = true;`. |
docs/src/install.md
Outdated
| sudo nix-channel --update | ||
| ``` | ||
|
|
||
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. |
There was a problem hiding this comment.
Remove the leading space inside the inline code to render and copy correctly: change security.sudo.wheelNeedsPassword = true; to security.sudo.wheelNeedsPassword = true;.
Suggested change
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. | |
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set `security.sudo.wheelNeedsPassword = true;`. |
| ``` | ||
|
|
||
| Don't forget to set a password for your user (default is `nixos` and is in the `wheel` group) in case you'll set ` security.sudo.wheelNeedsPassword = true;`. | ||
|
|
There was a problem hiding this comment.
[nitpick] Provide an explicit command example so readers can immediately act. Suggest adding a short snippet such as: 'Run passwd to set your password before enabling wheelNeedsPassword' followed by a code block:
passwd
# or, to set the 'nixos' user's password explicitly:
sudo passwd nixos
Suggested change
| You can set your password by running: | |
| ```bash | |
| passwd | |
| # or, to set the 'nixos' user's password explicitly: | |
| sudo passwd nixos |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note to set password before deploying new configuration, closes #829