-
-
Notifications
You must be signed in to change notification settings - Fork 3
docs: update the quickstart guide with additional steps and ToC #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis PR adds the term Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 LanguageTooldocs/quickstart.mdx[grammar] ~128-~128: There might be a mistake here. (QB_NEW_EN) [grammar] ~129-~129: There might be a mistake here. (QB_NEW_EN) [grammar] ~130-~130: There might be a mistake here. (QB_NEW_EN) [grammar] ~131-~131: There might be a mistake here. (QB_NEW_EN) [style] ~274-~274: Consider using a less common alternative to make your writing sound more unique and professional. (FEEL_FREE_TO_STYLE_ME) [style] ~368-~368: Consider shortening or rephrasing this to strengthen your wording. (MAKE_CHANGES) [grammar] ~378-~378: There might be a mistake here. (QB_NEW_EN) [grammar] ~379-~379: There might be a mistake here. (QB_NEW_EN) 🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d7481d1
to
eabb083
Compare
Nice and clear updates so far! |
f926f27
to
e0103ab
Compare
e0103ab
to
2ff929f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/.vale/styles/config/vocabularies/Suga/accept.txt
(1 hunks)docs/quickstart.mdx
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/quickstart.mdx
[grammar] ~128-~128: There might be a mistake here.
Context: ... name: app ``` The template includes: - target: AWS deployment configuration -...
(QB_NEW_EN)
[grammar] ~129-~129: There might be a mistake here.
Context: ...target: AWS deployment configuration - services: Your app
service with loca...
(QB_NEW_EN)
[grammar] ~130-~130: There might be a mistake here.
Context: ...al dev script and Docker container setup - buckets: A files
bucket that your ap...
(QB_NEW_EN)
[grammar] ~131-~131: There might be a mistake here.
Context: ...that your app can read from and write to - entrypoints: An HTTP endpoint that rou...
(QB_NEW_EN)
[style] ~274-~274: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...'ll start with a basic option here, but feel free to use your preferred method. <T...
(FEEL_FREE_TO_STYLE_ME)
[style] ~368-~368: Consider shortening or rephrasing this to strengthen your wording.
Context: ...i.my-first-app.example.com" ``` If you make changes to your application in future, you can re-...
(MAKE_CHANGES)
[locale-violation] ~368-~368: The phrase ‘in future’ is British English. Did you mean: “in the future”?
Context: ...If you make changes to your application in future, you can re-run suga build
to update ...
(IN_FUTURE)
[grammar] ~378-~378: There might be a mistake here.
Context: ...arning about Suga: - Projects overview - Platforms overview - [Add S...
(QB_NEW_EN)
[grammar] ~379-~379: There might be a mistake here.
Context: ...erview](/projects) - Platforms overview - [Add Suga to an existing application](/gu...
(QB_NEW_EN)
🔇 Additional comments (5)
docs/.vale/styles/config/vocabularies/Suga/accept.txt (1)
282-282
: Vocabulary term added for CLI tool.Adding "uv" aligns with the Python template references in the updated quickstart guide.
docs/quickstart.mdx (4)
128-133
: List formatting is clear, grammar warnings are likely false positives.The bullet-point list describing the template components reads well and is properly formatted for Markdown. The static analysis warnings appear to be false positives and can be safely ignored.
142-177
: Excellent tabbed structure for multi-language guidance.The addition of language-specific tabs (Node.js, Python, Go) with appropriate dependency and code generation commands makes the local development setup much clearer and more inclusive for different development environments.
272-287
: Cloud provider credentials section well-organized.The tabbed AWS/GCP configuration is a solid improvement. Grouping provider setup instructions separately makes the guide more maintainable and easier to extend if new providers are added.
305-332
: Provider-specific configuration guidance is well-structured.The separate AWS and GCP subsections with tabbed provider.tf and terraform.tfvars examples provide clear, actionable setup instructions. The note at line 335 about file persistence is helpful.
2ff929f
to
388b2c2
Compare
Fixes NIT-355
Submitting as a draft until the final input variable design for the GCP Platform is finalised, then we can update that last section and publish.