Skip to content

add check for code coming from UI, resync after validation errors clear #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

add check for code coming from UI, resync after validation errors clear #879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cli/internal/devserver/filesync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ func (fs *NitricFileSync) OnMessage(message json.RawMessage) {
return
}

validationErrors, err := validateApplicationSchema(buffer.Bytes())
if err != nil || len(validationErrors) > 0 {
return
}

err = fs.setApplicationFileContents(buffer.Bytes())
if err != nil {
fmt.Println("Error setting file contents:", err)
Expand Down Expand Up @@ -193,6 +198,9 @@ func (fs *NitricFileSync) watchFile() error {
debounced, cancel = lo.NewDebounce(fs.debounce, func() {
application, contents, err := fs.getApplicationFileContents()
if err != nil {
// Update contents so sync can be handled after validation errors clear
fs.lastSyncContents = contents

fileError = err

validationErrors, err := validateApplicationSchema(contents)
Expand Down