fix fullpath showing instead of cli binary name #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full file path was appearing using os.Args[0] when an alias is used to reference the cli binary.
|
@jyecusch is attempting to deploy a commit to the Nitric Team on Vercel. A member of the Team first needs to authorize it. |
davemooreuws
approved these changes
Jul 16, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
tjholm
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an alias to point at the binary file for the CLI the os.Args[0] value is a full path e.g.
/Users/you/somewhere/nitric/cli/bin/nitric. If there is a clever way to get around this I'm open to it. Otherwise, simplicity is probably the solution and we just use a string.Before:
After:
