Skip to content

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jul 15, 2025

No description provided.

Copy link

vercel bot commented Jul 15, 2025

@tjholm is attempting to deploy a commit to the Nitric Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nitric-docs ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 1:59am

@tjholm tjholm changed the title Add build button to edit screen Add build command and success/error messages to edit ws server Jul 15, 2025
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently breaks with no targets in nitric.yaml:

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x18 pc=0x1f3808d]

goroutine 21 [running]:
github.com/nitrictech/nitric/engines/terraform.(*TerraformEngine).Apply(0xc0009f4840, 0x0)
C:/projects/nitric/nitric/engines/terraform/terraform.go:459 +0x2d
github.com/nitrictech/nitric/cli/internal/devserver.(*NitricProjectBuild).OnMessage(0xc0004e2e80, {0xc000540740, 0x38, 0x40})
C:/projects/nitric/nitric/cli/internal/devserver/build.go:90 +0x37e

@tjholm tjholm requested a review from davemooreuws July 16, 2025 01:24
@tjholm
Copy link
Member Author

tjholm commented Jul 16, 2025

Currently breaks with no targets in nitric.yaml:

panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x18 pc=0x1f3808d]

goroutine 21 [running]: github.com/nitrictech/nitric/engines/terraform.(*TerraformEngine).Apply(0xc0009f4840, 0x0) C:/projects/nitric/nitric/engines/terraform/terraform.go:459 +0x2d github.com/nitrictech/nitric/cli/internal/devserver.(*NitricProjectBuild).OnMessage(0xc0004e2e80, {0xc000540740, 0x38, 0x40}) C:/projects/nitric/nitric/cli/internal/devserver/build.go:90 +0x37e

fixed by adding missing return statement

@tjholm tjholm merged commit 23078af into nitrictech:next Jul 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants