fix alias handling and upgrade to go >=1.24 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Go 1.22 the types package introduced a new
Aliastype, initially hidden behind aGODEBUGfield namedgotypesaliasso as not to break existing programs (like this linter). In Go 1.23 this behavior was enabled by default, breaking this package's tests for type alias handling in testdata/src/typealias. This PR makes those tests pass again.Separately, the go x/tools package has an issue with Go 1.25 (golang/go#74462) and this upgrades it as well. Unfortunately newer x/tools packages require Go >= 1.24, so AFAICT if you want to use it with Go 1.25 you can't also support Go 1.23. So this updates go.mod to specify a minimum version of 1.24.