Skip to content

revert #24896; asyncnet ssl overhaul #25033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

revert #24896; asyncnet ssl overhaul #25033

merged 2 commits into from
Jul 10, 2025

Conversation

nitely
Copy link
Contributor

@nitely nitely commented Jul 7, 2025 •
edited
Loading

revert #24896

Partially reverting #24896 in #25024 broke CI. So better revert it completely so the CI is green. I'll investigate the issue later.

@nitely nitely marked this pull request as ready for review July 7, 2025 22:20
@nitely nitely marked this pull request as draft July 8, 2025 00:32
@nitely nitely marked this pull request as ready for review July 8, 2025 01:19
@nitely nitely closed this Jul 8, 2025
@nitely
Copy link
Contributor Author

nitely commented Jul 8, 2025 •
edited
Loading

The issue is #25034. It fails when trying to do full-duplex on Windows. That never worked well and it hanged until the socket was closed or more data was sent, but #24896 behavior is worse as it can make it hang forever.

@nitely nitely reopened this Jul 8, 2025
@nitely nitely marked this pull request as draft July 8, 2025 04:48
@nitely nitely mentioned this pull request Jul 8, 2025
Closed
@nitely nitely closed this Jul 8, 2025
@nitely nitely reopened this Jul 8, 2025
@nitely nitely marked this pull request as ready for review July 8, 2025 07:17
@Araq Araq merged commit 08642ff into nim-lang:devel Jul 10, 2025
42 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 08642ff

Hint: mm: orc; opt: speed; options: -d:release
182768 lines; 8.557s; 659.508MiB peakmem

narimiran pushed a commit that referenced this pull request Jul 10, 2025
@nitely @narimiran
revert #24896; asyncnet ssl overhaul (#25033)
95d25a9 
revert #24896

Partially reverting #24896 in #25024 broke CI. So better revert it
completely so the CI is green. I'll investigate the issue later.

(cherry picked from commit 08642ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitely @Araq