feat(options): add second unsafeGet
that operates on var Option[T]
#25026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is
proc get*[T](self: var Option[T]): var T
, seems reasonable to also have unsafe version of it, because it is impossible to getvar T
fromvar Option[T]
without raising exceptions in a "safe" (or, rather, stdlib-provided) way. Since originalunsafeGet
didn't haverunnableExamples
, mine doesn't either, but simplest test case is the same as for the aforementionedget
:^ it works fine with my PR, but doesn't compile without it:
P.S. the
#get,Option[T]_2
in doc comment just links to the version ofget
that acceptsvar Option[T]
instead of normal one