Skip to content

Complete typing with strict checking #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Complete typing with strict checking #44

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d1bb8f
Complete typing with strict type-checking
Avasam Aug 25, 2024
57f332b
fix: add types-pytz module to support typed tests
Aug 26, 2024
ea7d59d
fix: mypy types
Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: run the tests
run: python3 tests.py
- name: verify type hints
run: mypy . --strict
run: mypy . --strict --enable-incomplete-feature=Unpack --install-types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--install-types will cause mypy to run twice. It's better to just know and install the stub-only packages you need ahead of time. I've updated my original PR.

- name: verify package install
run: python3 setup.py install --user
- name: verify we can import
Expand Down
Loading