nidaqmx: Update to released hightime/nitypes and fix mypy errors #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2025
bkeryan
force-pushed
the
users/bkeryan/hightime-typing
branch
from
8fa992e to
a692cf7
Compare
zhindes
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Update hightime and nitypes to released versions, from #858
This adds type hints for hightime. Previously, this package had no type hints, so the
ignore_missing_importssetting caused mypy to treathightime.datetimethe same astyping.Any.Fix most mypy failures, except for #860 which will require more thought.
Why should this Pull Request be merged?
Update to latest dependencies and import type safety.
What testing has been done?
Ran nps lint and mypy.