Skip to content

Spacing 👾 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2025
Merged

Spacing 👾 #321

merged 8 commits into from
Jul 23, 2025

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Jul 21, 2025

This should match reasonably close to the original figma mockups, in terms of heading spacing, and outer table spacing. Other changes are best guess, but this also sets up variables to make tweaking a bit easier.

Spacing: Add margin variables throughout
Attempt to match figma spacing with headings
Add variables for ol and ul colours (Colour needs a review for sure!)
Fix icons in callouts

Attempt to match figma spacing with headings
Add variables for ol and ul colours
@nginx-jack nginx-jack requested a review from a team as a code owner July 21, 2025 10:09
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/321/

Fix h1s on list pages not lining up with images
@nginx-jack nginx-jack requested a review from lamATnginx July 23, 2025 10:15
Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Approved. Looks great.

@lamATnginx lamATnginx merged commit 17d1dd9 into mainframe Jul 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants