generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 3
Spacing 👾 #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Spacing 👾 #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to match figma spacing with headings Add variables for ol and ul colours
✅ Deploy Preview will be available once build job completes!
|
lamATnginx
approved these changes
Jul 21, 2025
lamATnginx
requested changes
Jul 21, 2025
TasoOneAsia
reviewed
Jul 22, 2025
Fix h1s on list pages not lining up with images
lamATnginx
approved these changes
Jul 23, 2025
danielledeleo
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Approved. Looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should match reasonably close to the original figma mockups, in terms of heading spacing, and outer table spacing. Other changes are best guess, but this also sets up variables to make tweaking a bit easier.
Spacing: Add margin variables throughout
Attempt to match figma spacing with headings
Add variables for ol and ul colours (Colour needs a review for sure!)
Fix icons in callouts