Fixed how cards are arranged #301
Closed
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
nginx-jack
reviewed
Jul 7, 2025
| @@ -1248,6 +1249,24 @@ h6:has(a):hover { | |||
| &:not(:has(.featured-card)) *:nth-child(n + 3 of div.card-container) { | |||
| grid-column: 1 / -1; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I almost have a PR up for the content regrid with gird utilities. That would mean the cards themselves could be passed a param and decide how to be displayed. Can these changes hold off till then?
These selectors are amazing though 😂 .
There was a problem hiding this comment.
Yeah, it can wait. The existing change is non-breaking so this can wait.
|
Resolved in #304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed how cards are arranged. Should follow a "2-1" format correctly, where in a full subset of three cards, first two are half sized, and last one is full sized. In practical terms, every card should be half sized except last odd numbered card.
Before (for 5 cards):
After:
Before (for 4 cards):
After:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)