Skip to content

Callout: Remove whitespace when icon not included #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Callout: Remove whitespace when icon not included #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions exampleSite/content/test-product/tab-group/tab-group.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,22 @@ weight: 200

{{<tabs name="common_steps_for_nginx_oss_and_plus">}}

{{%tab name="Call Outs"%}}

{{<call-out "caution call-out" "Deprecated documentation notice" "fa fa-exclamation-triangle" >}}
This is a callout with an icon.
{{</call-out>}}

{{<caution>}}
This is a Caution callout. There was previously a bug with **bold text** that we should be aware of and continue to check for. This callout was invoked with the `<caution>` shortcode. It has no custom title.
{{</caution>}}

{{<call-out "" "Custom title">}}
This is a plain callout with a title. It has a [link](#plain-callouts) to a heading on this page. Its shortcode is `<call-out>` with a custom title parameter.
{{</call-out>}}

{{%/tab%}}

{{%tab name="Ordered List With Code Block types"%}}

1. Create the `/etc/ssl/nginx` directory:
Expand Down Expand Up @@ -40,6 +56,8 @@ nginx -s reload
```

{{%/tab%}}


{{</tabs>}}


Expand Down
12 changes: 6 additions & 6 deletions layouts/partials/callout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
{{/* Old frame callout */}}
<blockquote class="{{ $class }}" data-mf="false">
<div>
{{ with $icon }}
{{- with $icon -}}
<i class="{{ . }}"></i>
{{ end }}
{{- end -}}
<strong>{{ $title }}</strong>
{{ .content | markdownify }}
</div>
Expand Down Expand Up @@ -59,7 +59,7 @@
</div>
</blockquote>
</div>

{{ else }}

{{/* "Generic" mf callout */}}
Expand All @@ -68,13 +68,13 @@

<blockquote class="{{ $class }} note" data-mf="true" style="display: none;" data-title="{{ $cleanTitle }}">
<div class="callout-content">
{{ with $icon }}
{{- with $icon -}}
<i class="{{ . }}"></i>
{{ end }}
{{- end -}}
<div class="callout-content">
{{ .content | markdownify }}
</div>
</div>
</blockquote>

{{ end }}
{{ end }}
Loading