Skip to content

Headers: Fix duplicate oldframe header links #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Headers: Fix duplicate oldframe header links #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion exampleSite/content/test-product/everything.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,9 @@ This won't render anything.
<details open>
<summary>Learn how to pin NGINX Plus to a specific version</summary>
And this is the content on how to do so.
</details>
</details>

## [Heading with link](https://nginx.org/)

This is some text, under a heading with a link.
There was a bug, where if a heading had a link in it, it would get duplicated in old frame.
4 changes: 3 additions & 1 deletion layouts/_default/_markup/render-heading.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
</a>
</div>

<a class="headerlink float-right" data-mf="true" style="display: none;" href="#{{ .Anchor | safeURL }}" title="{{ .Text | safeHTML }}">
<div data-mf="true">
<a class="headerlink float-right" href="#{{ .Anchor | safeURL }}" title="{{ .Text | safeHTML }}">
{{ .Text | safeHTML }}
</a>
</div>
</h{{ .Level }}>
Loading