Skip to content

Added small fade on tabs when scrollable #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Mar 24, 2025

Proposed changes

Before:
Screenshot 2025-03-24 at 11 46 22 AM

After:
Screenshot 2025-03-24 at 11 45 44 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the enhancement New feature or request label Mar 24, 2025
@lamATnginx lamATnginx self-assigned this Mar 24, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 24, 2025 18:47
@nginx-jack
Copy link
Collaborator

I'm seeing an extra border (or something) on the right side when it's not scrolled over. I rebased with main locally, so maybe it's something to do with that. Can you reproduce?
Screenshot 2025-03-25 at 11 00 06
Screenshot 2025-03-25 at 10 59 59

@lamATnginx
Copy link
Collaborator Author

Yeah this one is a bit iffy since I was still unsure if the previous PR with z-index was going to break all of this. Will fix and finalize now.

@lamATnginx lamATnginx force-pushed the feat/fade-tab-scroll branch from c0af9ed to 47a1a17 Compare March 25, 2025 18:57
@lamATnginx
Copy link
Collaborator Author

Issue resolved now:

Screenshot 2025-03-25 at 11 57 33 AM

Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM locally 👍

@nginx-jack nginx-jack force-pushed the feat/fade-tab-scroll branch from 47a1a17 to 9fb8637 Compare March 26, 2025 11:39
@lamATnginx lamATnginx force-pushed the feat/fade-tab-scroll branch from 9fb8637 to 58abc97 Compare March 26, 2025 15:41
@lamATnginx lamATnginx merged commit db3660e into main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants