Skip to content

Add DirectiveSources field to ParseOptions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add DirectiveSources field to ParseOptions #97

merged 1 commit into from
Jun 25, 2024

Conversation

dengsh12
Copy link
Contributor

@dengsh12 dengsh12 commented Jun 14, 2024 •
edited
Loading

Proposed changes

Add a DirectiveSources field in ParseOptions. This field aims for users to indicate the OSS/N+ version, and dynamic modules they want to include for validation. If it is provided, it will be the only source of directives included in validation, and ParseOptions.MatchFuncs will be ignored

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dengsh12 dengsh12 requested a review from a team as a code owner June 14, 2024 17:04
@dengsh12 dengsh12 changed the title Change validation logic of matchFn to 'or' Change validation logic of matchFn to 'or' relation Jun 14, 2024
@dengsh12 dengsh12 self-assigned this Jun 14, 2024
@dengsh12 dengsh12 requested a review from ornj June 14, 2024 17:07
ornj
ornj reviewed Jun 14, 2024
View reviewed changes
@dengsh12 dengsh12 requested a review from ornj June 14, 2024 20:36
ornj
ornj reviewed Jun 14, 2024
View reviewed changes
@dengsh12 dengsh12 requested a review from ornj June 17, 2024 20:36
ornj
ornj reviewed Jun 17, 2024
View reviewed changes
@dengsh12 dengsh12 changed the title Change validation logic of matchFn to 'or' relation Add DirectiveSources field to DirectiveSources Jun 17, 2024
@dengsh12 dengsh12 changed the title Add DirectiveSources field to DirectiveSources Add DirectiveSources field to ParseOptions Jun 17, 2024
@dengsh12 dengsh12 requested a review from ornj June 18, 2024 15:51
@dengsh12 dengsh12 requested a review from nginx-nickc June 25, 2024 16:39
@dengsh12 dengsh12 merged commit 4082ece into nginxinc:main Jun 25, 2024
2 checks passed
@dengsh12 dengsh12 mentioned this pull request Jun 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ornj ornj ornj approved these changes

@nginx-nickc nginx-nickc nginx-nickc approved these changes

Assignees

@dengsh12 dengsh12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dengsh12 @ornj @nginx-nickc